fix: keep raw config edits scoped to config view (#1673) (thanks @Glucksberg)

src/agents/models-config.providers.ts

@@ -12,12 +12,7 @@ import {
   SYNTHETIC_BASE_URL,
   SYNTHETIC_MODEL_CATALOG,
 } from "./synthetic-models.js";
-import {
-  buildVeniceModelDefinition,
-  discoverVeniceModels,
-  VENICE_BASE_URL,
-  VENICE_MODEL_CATALOG,
-} from "./venice-models.js";
+import { discoverVeniceModels, VENICE_BASE_URL } from "./venice-models.js";
 
 type ModelsConfig = NonNullable<ClawdbotConfig["models"]>;
 export type ProviderConfig = NonNullable<ModelsConfig["providers"]>[string];

src/agents/models-config.skips-writing-models-json-no-env-token.test.ts

@@ -48,15 +48,29 @@ describe("models-config", () => {
       const previous = process.env.COPILOT_GITHUB_TOKEN;
       const previousGh = process.env.GH_TOKEN;
       const previousGithub = process.env.GITHUB_TOKEN;
+      const previousVenice = process.env.VENICE_API_KEY;
+      const previousKimiCode = process.env.KIMICODE_API_KEY;
+      const previousKimiCodeAlt = process.env.KIMI_CODE_API_KEY;
       const previousMinimax = process.env.MINIMAX_API_KEY;
       const previousMoonshot = process.env.MOONSHOT_API_KEY;
       const previousSynthetic = process.env.SYNTHETIC_API_KEY;
+      const previousAwsAccessKey = process.env.AWS_ACCESS_KEY_ID;
+      const previousAwsSecretKey = process.env.AWS_SECRET_ACCESS_KEY;
+      const previousAwsProfile = process.env.AWS_PROFILE;
+      const previousAwsBearer = process.env.AWS_BEARER_TOKEN;
       delete process.env.COPILOT_GITHUB_TOKEN;
       delete process.env.GH_TOKEN;
       delete process.env.GITHUB_TOKEN;
+      delete process.env.VENICE_API_KEY;
+      delete process.env.KIMICODE_API_KEY;
+      delete process.env.KIMI_CODE_API_KEY;
       delete process.env.MINIMAX_API_KEY;
       delete process.env.MOONSHOT_API_KEY;
       delete process.env.SYNTHETIC_API_KEY;
+      delete process.env.AWS_ACCESS_KEY_ID;
+      delete process.env.AWS_SECRET_ACCESS_KEY;
+      delete process.env.AWS_PROFILE;
+      delete process.env.AWS_BEARER_TOKEN;
 
       try {
         vi.resetModules();
@@ -79,12 +93,26 @@ describe("models-config", () => {
         else process.env.GH_TOKEN = previousGh;
         if (previousGithub === undefined) delete process.env.GITHUB_TOKEN;
         else process.env.GITHUB_TOKEN = previousGithub;
+        if (previousVenice === undefined) delete process.env.VENICE_API_KEY;
+        else process.env.VENICE_API_KEY = previousVenice;
+        if (previousKimiCode === undefined) delete process.env.KIMICODE_API_KEY;
+        else process.env.KIMICODE_API_KEY = previousKimiCode;
+        if (previousKimiCodeAlt === undefined) delete process.env.KIMI_CODE_API_KEY;
+        else process.env.KIMI_CODE_API_KEY = previousKimiCodeAlt;
         if (previousMinimax === undefined) delete process.env.MINIMAX_API_KEY;
         else process.env.MINIMAX_API_KEY = previousMinimax;
         if (previousMoonshot === undefined) delete process.env.MOONSHOT_API_KEY;
         else process.env.MOONSHOT_API_KEY = previousMoonshot;
         if (previousSynthetic === undefined) delete process.env.SYNTHETIC_API_KEY;
         else process.env.SYNTHETIC_API_KEY = previousSynthetic;
+        if (previousAwsAccessKey === undefined) delete process.env.AWS_ACCESS_KEY_ID;
+        else process.env.AWS_ACCESS_KEY_ID = previousAwsAccessKey;
+        if (previousAwsSecretKey === undefined) delete process.env.AWS_SECRET_ACCESS_KEY;
+        else process.env.AWS_SECRET_ACCESS_KEY = previousAwsSecretKey;
+        if (previousAwsProfile === undefined) delete process.env.AWS_PROFILE;
+        else process.env.AWS_PROFILE = previousAwsProfile;
+        if (previousAwsBearer === undefined) delete process.env.AWS_BEARER_TOKEN;
+        else process.env.AWS_BEARER_TOKEN = previousAwsBearer;
       }
     });
   });

src/agents/venice-models.ts

@@ -340,7 +340,9 @@ export async function discoverVeniceModels(): Promise<ModelDefinitionConfig[]> {
     });
 
     if (!response.ok) {
-      console.warn(`[venice-models] Failed to discover models: HTTP ${response.status}, using static catalog`);
+      console.warn(
+        `[venice-models] Failed to discover models: HTTP ${response.status}, using static catalog`,
+      );
       return VENICE_MODEL_CATALOG.map(buildVeniceModelDefinition);
     }
 
@@ -351,7 +353,9 @@ export async function discoverVeniceModels(): Promise<ModelDefinitionConfig[]> {
     }
 
     // Merge discovered models with catalog metadata
-    const catalogById = new Map(VENICE_MODEL_CATALOG.map((m) => [m.id, m]));
+    const catalogById = new Map<string, VeniceCatalogEntry>(
+      VENICE_MODEL_CATALOG.map((m) => [m.id, m]),
+    );
     const models: ModelDefinitionConfig[] = [];
 
     for (const apiModel of data.data) {